linux-kernel - [PATCH 0/2] leds: some issues with hardware blinking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri,  7 Oct 2011 00:03:29 +0200
From:	Antonio Ospite <ospite@...denti.unina.it>
To:	Richard Purdie <rpurdie@...ys.net>
Cc:	Antonio Ospite <ospite@...denti.unina.it>,
	Johannes Berg <johannes.berg@...el.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH 0/2] leds: some issues with hardware blinking

Hi,

having software fall-back for blinking when hardware blinking does not
work or is not available is really good, however there are some cases
which are not covered in the current implementation. See the two
following patches.

The first one is needed to make the "timer" trigger work at all when
hardware blinking is available.

The second one is more like an RFC, since I am not sure I like the way I
fixed it, but the issue is there: mixing hardware and software blinking
can leave the timer on when not needed.

Thanks,
   Antonio

Antonio Ospite (2):
  leds: save the delay values after a successful call to blink_set()
  leds: turn the blink_timer off before starting to blink

 drivers/leds/led-class.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

--
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/