linux-kernel - Re: [PATCH 2/2] Staging: comedi: fix brace coding and whitespace issue in ni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 9 Oct 2011 01:05:40 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	JAke Burton <jake5991@...e.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	fmhess@...rs.sourceforge.net, abbotti@....co.uk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Staging: comedi: fix brace coding and whitespace
 issue in ni_atmio.c

Nah.  For this kind of thing you need to redo the first one, not
just write another patch on top of it.  The v2 patch should have a
subject with [patch v2] blah blah blah.  After the Signed-off-by line
put three dashes "---" and then the changes between v1 and v2.

Signed-off-by:  you
---
v2:  whitespace changes for Joe Perches.

Joe should be added to the CC list.  Hopefully it should be sent in
the same thread as a response to Joe's email.  Use the In-Reply-To
header.

Also the "};" on the first hunk should be moved down a line as well.

And the subject and the commit message on the first patch were
mangled.  There wasn't a blank line after the Subject and before the
changelog.  It need another blank line in front of the Signed-off-by
line and this patch doesn't have a Signed-off-by line.  (These things
matter because the process is scripted).

If you want you can leave linux-kernel off the CC list.  They don't
care about whitespace patches to staging.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/