linux-kernel - Re: [PATCH v9]: Improve performance of LZO/plain hibernation, check image with CRC32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 10 Oct 2011 11:10:52 +1100
From:	Bojan Smojver <bojan@...ursive.com>
To:	linux-kernel@...r.kernel.org
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH v9]: Improve performance of LZO/plain hibernation, check
 image with CRC32

On Mon, 2011-10-10 at 10:53 +1100, Bojan Smojver wrote:
>  static void release_swap_reader(struct swap_map_handle *handle)
>  {
> -       if (handle->cur)
> -               free_page((unsigned long)handle->cur);
> +       struct swap_map_page_list *tmp;
> +
> +       while (handle->maps) {
> +               if (handle->maps->map)
> +                       free_page((unsigned long)handle->maps->map);
> +               tmp = handle->maps;
> +               handle->maps = handle->maps->next;
> +               kfree(tmp);
> +       }
>         handle->cur = NULL;
> +       handle->maps = NULL;
>  } 

Obviously, that handle->maps = NULL is redundant there.

PS. It's funny how errors only become visible once you send them
out. :-)

-- 
Bojan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/