linux-kernel - Re: [PATCH 0/6] udf: Change some KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Oct 2011 19:24:32 +0900
From:	NamJae Jeon <linkinjeon@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Jan Kara <jack@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/6] udf: Change some KERN_<level>s and logging neatening

2011/10/10 Joe Perches <joe@...ches.com>:
> I reviewed your patch and think it's too large
> for others to review because it combines multiple
> things into a single patch.
>
> I think that adding struct super_block * to udb_debug
> isn't necessary or particularly useful.
>
> Here are the changes to your original patch that I made:
>
> Separate a single large patch into reviewable chunks.
> Don't convert every message type to udf_<foo>.
Hi Joe.
Thank you, you are given a nice clean up.
>
> Joe Perches (6):
>  udf: Promote some debugging messages to udf_error
>  udf: Rename udf_error to udf_err
>  udf: Rename udf_warn to udf_warn
>  udf: Convert printks to pr_<level>
>  udf: Neaten logging output, use vsprintf extension %pV
>  udf: Neaten udf_debug uses
>
>  fs/udf/balloc.c    |   14 ++--
>  fs/udf/directory.c |    8 +-
>  fs/udf/inode.c     |   36 ++++-----
>  fs/udf/lowlevel.c  |    2 +-
>  fs/udf/misc.c      |   24 ++++---
>  fs/udf/namei.c     |    5 +-
>  fs/udf/partition.c |   11 +--
>  fs/udf/super.c     |  214 +++++++++++++++++++++++-----------------------------
>  fs/udf/truncate.c  |   21 ++---
>  fs/udf/udfdecl.h   |   35 ++++++---
>  fs/udf/udftime.c   |    3 +-
>  fs/udf/unicode.c   |    6 +-
>  12 files changed, 178 insertions(+), 201 deletions(-)
>
> --
> 1.7.6.405.gc1be0
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/