linux-kernel - Re: [PATCH 4/6] udf: Convert printks to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Oct 2011 18:41:57 +0200
From:	Jan Kara <jack@...e.cz>
To:	Joe Perches <joe@...ches.com>
Cc:	Jan Kara <jack@...e.cz>, NamJae Jeon <linkinjeon@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] udf: Convert printks to pr_<level>

On Mon 10-10-11 08:23:34, Joe Perches wrote:
> On Mon, 2011-10-10 at 16:59 +0200, Jan Kara wrote:
> > On Mon 10-10-11 01:08:05, Joe Perches wrote:
> > > Use the current logging styles.
> > > 
> > > Convert a few printks that should have been udf_warn and udf_err.
> > > Coalesce formats.  Add #define pr_fmt.
> > > Move an #include "udfdecls.h" above other includes in udftime.c
> > > so pr_fmt works correctly.  Strip prefixes from conversions as appropriate.
> > > Reorder logging definitions in udfdecl.h
> >   Any reason why you didn't use udf_err() / udf_warn() in all the places
> > where sb pointer is available?
> 
> Oh, I forgot to mention that udf_err emits at KERN_CRIT.
> I think that's not good.
> 
> It's either an error or it's a critical notification
> and the pr_crit should be pr_err or the function should
> be renamed.
  Yeah, good point. I've changed udf_err() to call pr_err() because
KERN_CRIT is really too much.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/