linux-kernel - Re: [PATCH] leds-class: change back LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Oct 2011 22:54:09 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Bryan Wu <bryan.wu@...onical.com>
Cc:	tony@...mide.com, linux@....linux.org.uk, rpurdie@...ys.net,
	manuel.lauss@...il.com, cjb@...top.org, dwmw2@...radead.org,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
	linus.walleij@...aro.org, akpm@...gle.com
Subject: Re: [PATCH] leds-class: change back LEDS_CLASS to tristate instead
 of bool

On Tue, Sep 27, 2011 at 04:50:32PM +0800, Bryan Wu wrote:
> LEDS_CLASS is required by leds and trigger drivers, but we can build it as
> module.  So change this option back as tristate and treak the help message
> as well.
> 
> LEDS_TRIGGERS depends on LEDS_CLASSS, which should be tristate.  So set it
> as tristate too and update header files as well.
> 
> Change those ifdefs to take care of module configuration.
> 
> Signed-off-by: Bryan Wu <bryan.wu@...onical.com>

Won't this break linking if POWER_SUPPLY=y and LEDS_TRIGGERS=m?

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/