linux-kernel - Re: [PATCHv5 16/19] power_supply: Convert all users to new usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Oct 2011 23:08:12 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv5 16/19] power_supply: Convert all users to new usb_phy

On Mon, Oct 03, 2011 at 04:10:55PM +0300, Heikki Krogerus wrote:
[...]
> > +static inline int
> > +isp1704_read(struct isp1704_charger *isp, u32 reg)

Cosmetic nitpick: I don't see any reason to break this into two lines.

> > +{
> > +	return usb_phy_io_read(isp->xceiv, reg);
> > +}
> > +
> > +static inline int
> > +isp1704_write(struct isp1704_charger *isp, u32 val, u32 reg)

Same here.

I assume you want this patch to go via some other tree, so feel
free to add

Acked-by: Anton Vorontsov <cbouatmailru@...il.com>

Thanks!

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/