linux-kernel - Re: [Patch 2/2] gpio-pca953x: fix gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Oct 2011 09:37:10 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Hartmut Knaack <knaack.h@....de>
CC:	Grant Likely <grant.likely@...retlab.ca>,
	linux-kernel@...r.kernel.org
Subject: Re: [Patch 2/2] gpio-pca953x: fix gpio_base and add verbosity

On 11/10/11 09:22, Hartmut Knaack wrote:

> Inspired by the gpio-pcf857x driver, this patch will output information
> about the instantiated gpio-chip, including gpio start and end, chip
> type and if irq is used.
> 
> Signed-off-by: Hartmut Knaack <knaack.h@....de>
> -------------------------------------------------------------
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index ae479fd..4bdb88e 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -683,6 +683,12 @@ static int __devinit pca953x_probe(struct
> i2c_client *client,
>      if (ret)
>          goto out_failed;
>  
> +    dev_info(&client->dev, "gpios %d..%d added on a %s%s\n",
> +         chip->gpio_chip.base,
> +         chip->gpio_chip.base + chip->gpio_chip.ngpio - 1,
> +         client->name,
> +         client->irq ? " (irq ignored)" : "");
> +   


If we want this, why not move it into gpiochip_add rather than
duplicating it in each driver? If you want to keep it here it should
probably be moved below the gpiochip_add, since the above would still
print if gpiochip_add failed.

>      ret = gpiochip_add(&chip->gpio_chip);
>      if (ret)
>          goto out_failed_irq;
> 


~Ryan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/