linux-kernel - Re: [PATCH] regmap: Warn on raw I/O as well as bulk reads that bypass cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Oct 2011 10:01:17 +0100
From:	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: Warn on raw I/O as well as bulk reads that
	bypass cache

On Sun, Oct 09, 2011 at 02:38:54PM +0100, Mark Brown wrote:
> As with the bulk reads we really should be able to make these play
> nicely with the cache but warn for now.
> 
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>  drivers/base/regmap/regmap.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
> index d786ddc..85bffdd 100644
> --- a/drivers/base/regmap/regmap.c
> +++ b/drivers/base/regmap/regmap.c
> @@ -377,6 +377,8 @@ int regmap_raw_write(struct regmap *map, unsigned int reg,
>  {
>  	int ret;
>  
> +	WARN_ON(map->cache_type != REGCACHE_NONE);
> +
>  	mutex_lock(&map->lock);
>  
>  	ret = _regmap_raw_write(map, reg, val, val_len);
> @@ -481,6 +483,8 @@ int regmap_raw_read(struct regmap *map, unsigned int reg, void *val,
>  {
>  	int ret;
>  
> +	WARN_ON(map->cache_type != REGCACHE_NONE);
> +
>  	mutex_lock(&map->lock);
>  
>  	ret = _regmap_raw_read(map, reg, val, val_len);
> -- 
> 1.7.6.3

All of them look good.

Acked-by: Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/