linux-kernel - [PATCH -rt] hrtimer: Add missing debug_activate() aid [Was: Re: [ANNOUNCE] 3.0.6-rt17]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 Oct 2011 15:52:30 +0800
From:	Yong Zhang <yong.zhang0@...il.com>
To:	Fernando Lopez-Lezcano <nando@...ma.stanford.edu>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-rt-users <linux-rt-users@...r.kernel.org>
Subject: [PATCH -rt] hrtimer: Add missing debug_activate() aid [Was: Re:
 [ANNOUNCE] 3.0.6-rt17]

On Fri, Oct 07, 2011 at 10:25:25AM -0700, Fernando Lopez-Lezcano wrote:
> On 10/06/2011 06:15 PM, Thomas Gleixner wrote:
> >Dear RT Folks,
> >
> >I'm pleased to announce the 3.0.6-rt17 release.
> 
> Hi and thanks again. So far this one is not hanging which is very
> good news. But I still see the hrtimer_fixup_activate warnings I
> reported for rt16...

Hi Fernando,

I think below patch will smooth your concern?

Thanks,
Yong

---
From: Yong Zhang <yong.zhang0@...il.com>
Subject: [PATCH -rt] hrtimer: Add missing debug_activate() aid

It will fix below warning, which is also reported by Fernando:

[    7.616090] ------------[ cut here ]------------
[    7.616093] WARNING: at kernel/hrtimer.c:391 hrtimer_fixup_activate+0x27/0x50()
[    7.616094] Hardware name: OptiPlex 755
[    7.616096] Modules linked in:
[    7.616099] Pid: 0, comm: kworker/0:0 Tainted: G        W 3.0.6-rt17-00284-g9d73a61 #15
[    7.616100] Call Trace:
[    7.616103]  [<c014d9a2>] warn_slowpath_common+0x72/0xa0
[    7.616106]  [<c0175417>] ? hrtimer_fixup_activate+0x27/0x50
[    7.616109]  [<c0175417>] ? hrtimer_fixup_activate+0x27/0x50
[    7.616112]  [<c014d9f2>] warn_slowpath_null+0x22/0x30
[    7.616115]  [<c0175417>] hrtimer_fixup_activate+0x27/0x50
[    7.616118]  [<c03b3ab0>] debug_object_activate+0x100/0x130
[    7.616121]  [<c0176b96>] ? hrtimer_start_range_ns+0x26/0x30
[    7.616123]  [<c0175a59>] enqueue_hrtimer+0x19/0x100
[    7.616126]  [<c0176b96>] ? hrtimer_start_range_ns+0x26/0x30
[    7.616129]  [<c0176744>] __hrtimer_start_range_ns+0x144/0x540
[    7.616132]  [<c072705a>] ? _raw_spin_unlock_irqrestore+0x3a/0x80
[    7.616136]  [<c0176b96>] hrtimer_start_range_ns+0x26/0x30
[    7.616139]  [<c01852b5>] tick_nohz_restart_sched_tick+0x185/0x1b0
[    7.616142]  [<c0101878>] cpu_idle+0x98/0xc0
[    7.616146]  [<c071fcd8>] start_secondary+0x1d3/0x1da
[    7.616148] ---[ end trace 0000000000000003 ]---

Reported-by: Fernando Lopez-Lezcano <nando@...ma.stanford.edu>
Signed-off-by: Yong Zhang <yong.zhang0@...il.com>
---
 kernel/hrtimer.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c
index dfa77c5..af89591 100644
--- a/kernel/hrtimer.c
+++ b/kernel/hrtimer.c
@@ -1040,6 +1040,7 @@ int __hrtimer_start_range_ns(struct hrtimer *timer, ktime_t tim,
 			 * remove it again and report a failure. This avoids
 			 * stale base->first entries.
 			 */
+			debug_deactivate(timer);
 			__remove_hrtimer(timer, new_base,
 					timer->state & HRTIMER_STATE_CALLBACK, 0);
 		}
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/