linux-kernel - Re: [PATCH] nfs-utils: mount: really return from errno test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Oct 2011 13:19:55 -0400
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	Steve Dickson <SteveD@...hat.com>
Cc:	Chuck Lever <chuck.lever@...cle.com>, Hamo <hamo.by@...il.com>,
	linux-nfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfs-utils: mount: really return from errno test

This is by design.

NFSv3 and NFSv4 have no server-side identifiers to inform us that we may
be talking to the same server, and so we don't worry about doing so.

An NFSv4.1 server can tell you that this is the same server replying on
different IP addresses. We are planning on adding proper support for
that, but I don't believe we've currently got it right.

Cheers
  Trond

On Thu, 2011-10-13 at 12:59 -0400, Steve Dickson wrote: 
> Looking further into this issue, I noticed all the following 
> mounts were successful.
> 
> # mount -o v3 localhost:/home /mnt/home
> # mount -o v4 localhost:/home /mnt/home
> # mount -o v4 [fec0::2:5652:ff:fe20:8459]:/home /mnt/home
> # mount -o v3 [fec0::2:5652:ff:fe20:8459]:/home /mnt/home
> 
> which the mount point, /mnt/home is mounted 4 different times 
> to the same server. 
> 
> Is by design or a real problem?
> 
> steved.
> 
> 
> On 10/13/2011 12:34 PM, Steve Dickson wrote:
> > Yeah... I believe its this one
> >    https://bugzilla.redhat.com/show_bug.cgi?id=744657
> > 
> > On 10/13/2011 10:53 AM, Chuck Lever wrote:
> >> What was the presenting problem?  Is there a bugzilla report I can look at?
> >>
> >> On Oct 11, 2011, at 5:44 AM, Hamo wrote:
> >>
> >>> We should only try next address family if we meet ECONNREFUSED or EHOSTUNREACH
> >>> for v4 or ECONNREFUSED or EOPNOTSUPP or EHOSTUNREACH for v3v2.
> >>> Before, only a break in swich can not make the program out of for loop.
> >>>
> >>> Signed-off-by: Yang Bai <hamo.by@...il.com>
> >>> ---
> >>> utils/mount/stropts.c |    6 ++++--
> >>> 1 files changed, 4 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> >>> index 314a806..4032bf3 100644
> >>> --- a/utils/mount/stropts.c
> >>> +++ b/utils/mount/stropts.c
> >>> @@ -665,9 +665,10 @@ static int nfs_try_mount_v3v2(struct nfsmount_info *mi)
> >>> 		case EHOSTUNREACH:
> >>> 			continue;
> >>> 		default:
> >>> -			break;
> >>> +			goto out;
> >>> 		}
> >>> 	}
> >>> +out:
> >>> 	return ret;
> >>> }
> >>>
> >>> @@ -751,9 +752,10 @@ static int nfs_try_mount_v4(struct nfsmount_info *mi)
> >>> 		case EHOSTUNREACH:
> >>> 			continue;
> >>> 		default:
> >>> -			break;
> >>> +			goto out;
> >>> 		}
> >>> 	}
> >>> +out:
> >>> 	return ret;
> >>> }
> >>>
> >>> -- 
> >>> 1.7.1
> >>> --
> >>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> >>> the body of a message to majordomo@...r.kernel.org
> >>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >>
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@...app.com
www.netapp.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/