linux-kernel - Re: [Patch V2 2/2] gpio-pca953x: fix gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Oct 2011 13:35:38 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Hartmut Knaack <knaack.h@....de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [Patch V2 2/2] gpio-pca953x: fix gpio_base and add verbosity

On Tue, Oct 11, 2011 at 11:45:56AM +0200, Hartmut Knaack wrote:
> Sorry, I messed up the porting from my work files to clean git repo.
> This should be right now.
> Inspired by the gpio-pcf857x driver, this patch will output information
> about the instantiated gpio-chip, including gpio start and end, chip
> type and if irq is used.
> 
> Signed-off-by: Hartmut Knaack <knaack.h@....de>
> -------------------------------------------------------------
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 0721d85..f1a4fad 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -687,6 +687,12 @@ static int __devinit pca953x_probe(struct
> i2c_client *client,
>  	if (ret)
>  		goto out_failed_irq;
> 
> +	dev_info(&client->dev, "gpios %d..%d added on a %s%s\n",
> +		 chip->gpio_chip.base,
> +		 chip->gpio_chip.base + chip->gpio_chip.ngpio - 1,
> +		 client->name,
> +		 client->irq ? " (irq ignored)" : "");
> +

dev_dbg() for this I think.

>  	if (pdata && pdata->setup) {
>  		ret = pdata->setup(client, chip->gpio_chip.base,
>  				chip->gpio_chip.ngpio, pdata->context);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/