linux-kernel - Re: [PATCH 2/2] acerhdf: Add support for new hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 Oct 2011 11:38:41 +0200
From:	Peter Feuerer <peter@...e.net>
To:	Borislav Petkov <bp@...en8.de>
Cc:	mjg@...hat.com, linux-kernel@...r.kernel.org,
	Borislav Petkov <petkovbb@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/2] acerhdf: Add support for new hardware

Borislav Petkov writes:

> On Sun, Oct 16, 2011 at 01:28:11AM +0200, Peter Feuerer wrote: 
>> Borislav Petkov writes:
>> >On Fri, Oct 14, 2011 at 11:43:34PM +0200, Peter Feuerer wrote:
>> >>From: Peter Feuerer <peter@...e.net>
>> >>
>> >>Add support for new hardware:
>> >>Acer Aspire LT-10Q/531/751/1810/1825,
>> >>Acer Travelmate 7730,
>> >>Packard Bell ENBFT/DOTVR46
>> >>
>> >>To prevent from hardware defects, the default temperature values have been
>> >>decreased.
>> >
>> >do you have some actual bug reports stating that the original
>> >temperature values were causing hw defects?
>> 
>> Fortunately not. But due to new supported hardware, of which I don't
>> know the actual temperature limits of processor, harddisk and other
>> components, it just feels safer with this lower settings.
>> 
>> Another point is, that you need to have the "kernelmode=1" option
>> when loading the module to enable fan control. When searching the
>> internet for acerhdf tutorials, you see, everybody not only setting
>> kernelmode=1 but also setting the fanon and fanoff variables. So I
>> think it won't change anything for most people.
>> 
>> Furthermore seems like kernel and userspace tools have been improved
>> to work more efficient and my netbook doesn't get so hot anymore,
>> for me it stays most of the time at about 50 degree when doing
>> office stuff and surfing.
> 
> Ok, good. Sounds to me like this above should be the commit message
> instead of the one sentence you had before because it explains much
> better why you're doing what you're doing with the patch.
> 
> Also, the "add support" part should be another patch because
> conceptually it doesn't belong with the temperature changes.

Okay, will split the patches and resend the series.

Thanks a lot
kind regards,
--peter;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/