linux-kernel - Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Oct 2011 14:07:11 +0300
From:	"Kasatkin, Dmitry" <dmitry.kasatkin@...el.com>
To:	James Morris <jmorris@...ei.org>
Cc:	linux-security-module@...r.kernel.org,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	zohar@...ux.vnet.ibm.com, dhowells@...hat.com,
	herbert@...dor.hengli.com.au
Subject: Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

On Mon, Oct 17, 2011 at 12:11 PM, Kasatkin, Dmitry
<dmitry.kasatkin@...el.com> wrote:
> From Kernel Docbook
>
>    Similar to <function>EXPORT_SYMBOL()</function> except that the
>    symbols exported by <function>EXPORT_SYMBOL_GPL()</function> can
>    only be seen by modules with a
>    <function>MODULE_LICENSE()</function> that specifies a GPL
>    compatible license.  It implies that the function is considered
>    an internal implementation issue, and not really an interface.
>
> "not really an interface"....
>
> Should it really be EXPORT_SYMBOL_GPL?
>
> - Dmitry
>
> On Sat, Oct 15, 2011 at 3:28 AM, James Morris <jmorris@...ei.org> wrote:
>> On Fri, 14 Oct 2011, Dmitry Kasatkin wrote:
>>
>>> +MPI mpi_alloc(unsigned nlimbs)
>>> +{
>>> +     MPI a;
>>> +
>>> +     a = (MPI) kmalloc(sizeof *a, GFP_KERNEL);
>>
>> Generally, typedef structs are frowned upon in the kernel.  I'd prefer to
>> see this (and any others) changed to a normal type.
>>
>> Also, kmalloc return values do not need to be cast, they're void *.
>>
>>> +EXPORT_SYMBOL(mpi_alloc);
>>
>> New interfaces should be EXPORT_SYMBOL_GPL.
>>
>>
>> --
>> James Morris
>> <jmorris@...ei.org>
>>
>

Hello James,

Also please let me know about other things so that I could fix them as well...

Thanks!

- Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/