| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Oct 2011 22:33:03 +0100 From: Mark Brown <broonie@...nsource.wolfsonmicro.com> To: Grant Likely <grant.likely@...retlab.ca> Cc: Kukjin Kim <kgene.kim@...sung.com>, Grant Likely <grant@...retlab.ca>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com Subject: Re: [PATCH] gpio/samsung: Complain loudly if we don't know the SoC On Mon, Oct 17, 2011 at 03:07:47PM -0600, Grant Likely wrote: > On Mon, Oct 17, 2011 at 3:04 PM, Mark Brown > > If we don't know the SoC type then we won't add any chips which is rather > > unfortunate as neither GPIO nor pinmux APIs will work, breaking lots of > > different subsystems. Logging at least provides a hint to the user as to > > what's gone wrong. > > Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com> > Be Bolder! May as well use WARN() and be really obnoxious. :-) Actually what's really unfortunate here is that in most configurations this will cause a catastrophic failure to boot so we never get far enough to see the logging at all. We really need aSCREAM_THROUGH_DEBUG_LL() or whatever. Or to fix these things to dump via that route if we don't have the console up yet, which is going to be more practical. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists