linux-kernel - Re: [PATCH v5 10/10] x86, efi: EFI boot stub support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Oct 2011 08:09:47 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Maarten Lankhorst <m.b.lankhorst@...il.com>
Cc:	Matt Fleming <matt@...sole-pimps.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Matthew Garrett <mjg@...hat.com>, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
	Matt Fleming <matt.fleming@...el.com>,
	Mike Waychison <mikew@...gle.com>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH v5 10/10] x86, efi: EFI boot stub support


* Maarten Lankhorst <m.b.lankhorst@...il.com> wrote:

[ a 833 lines of TOTALLY POINTLESS QUOTE ]

> > +			status = low_alloc(options_size, 1, &cmdline);
> > +			if (status != EFI_SUCCESS)
> > +				goto fail;
> Shouldn't this be options_size + 1?
> > +
> > +			s1 = (u8 *)(unsigned long)cmdline;
> > +			s2 = (u16 *)options;
> > +
> > +			for (i = 0; i < options_size - 1; i++)
> > +				*s1++ = *s2++;
> > +
> > +			*s1 = '\0';
> For this null character..
> > +		}

[ another 700+ lines of TOTALLY POINTLESS QUOTE ]

It took me 3 attempts to find your comments in the 1500 lines of 
email.

Please format your emails! If you quote on 20 lines of patch then you 
absolutely HAVE TO cut out the remaining 1500 lines you did not 
comment on ...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/