linux-kernel - Re: [PATCH -V7 21/26] richacl: xattr mapping functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Oct 2011 12:52:10 +0200
From:	Andreas Gruenbacher <agruen@...nel.org>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	"J. Bruce Fields" <bfields@...ldses.org>,
	Christoph Hellwig <hch@...radead.org>,
	akpm@...ux-foundation.org, viro@...iv.linux.org.uk,
	dhowells@...hat.com, linux-fsdevel@...r.kernel.org,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -V7 21/26] richacl: xattr mapping functions

On Fri, 2011-10-21 at 15:10 +0530, Aneesh Kumar K.V wrote:
> How about the below change. This will require richacl tools change
> also.

>  I made the e_flags 32 bit to make sure we don't take the space
>  needed NFSv4 ACL related flags.

But struct richace_xattr has a hole now.  

There's ample of space left in the 16-bit field; I don't think there is
a need to extend it.  If the need should ever arise, we can still define
a new version of the xattr format.  Also, this change creates a hole in
struct richace_xattr; we can't do that.

> +#define ACE4_SPECIAL_WHO		0x80000000
> +#define ACE4_UNIXID_WHO			0x40000000

Can the ACE4_UNIXID_WHO flag please be removed again?  It isn't needed,
it just creates a mess.

Thanks,
Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/