linux-kernel - Re: [PATCH 1/3] ASoC: wm8940: Fix setting PLL Output clock division ratio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Oct 2011 13:06:08 +0100
From:	"Girdwood, Liam" <lrg@...com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH 1/3] ASoC: wm8940: Fix setting PLL Output clock division ratio

On 24 October 2011 04:32, Axel Lin <axel.lin@...il.com> wrote:
> According to the datasheet:
> The PLL Output clock division ratio is controlled by BIT[5:4] of
> WM8940_GPIO register(08h).
> Current code read/write the WM8940_ADDCNTRL(07h) register which is wrong.
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  sound/soc/codecs/wm8940.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8940.c b/sound/soc/codecs/wm8940.c
> index a4abfdf..3cc3bce 100644
> --- a/sound/soc/codecs/wm8940.c
> +++ b/sound/soc/codecs/wm8940.c
> @@ -627,8 +627,8 @@ static int wm8940_set_dai_clkdiv(struct snd_soc_dai *codec_dai,
>                ret = snd_soc_write(codec, WM8940_CLOCK, reg | (div << 5));
>                break;
>        case WM8940_OPCLKDIV:
> -               reg = snd_soc_read(codec, WM8940_ADDCNTRL) & 0xFFCF;
> -               ret = snd_soc_write(codec, WM8940_ADDCNTRL, reg | (div << 4));
> +               reg = snd_soc_read(codec, WM8940_GPIO) & 0xFFCF;
> +               ret = snd_soc_write(codec, WM8940_GPIO, reg | (div << 4));
>                break;
>        }
>        return ret;
> --

Acked-by: Liam Girdwood <lrg@...com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/