linux-kernel - Re: [PATCH] Add SoundCard driver for OKI SEMICONDUCTOR ML7213 IOH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Oct 2011 21:12:42 +0900
From:	Tomoya MORINAGA <tomoya-linux@....lapis-semi.com>
To:	Takashi Iwai <tiwai@...e.de>
CC:	perex@...ex.cz, linux-kernel@...r.kernel.org,
	"Wang, Qi" <qi.wang@...el.com>,
	"Wang, Yong Y" <yong.y.wang@...el.com>,
	"Clark, Joel" <joel.clark@...el.com>,
	"Ewe, Kok Howg" <kok.howg.ewe@...el.com>,
	Liam Girdwood <lrg@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] Add SoundCard driver for OKI SEMICONDUCTOR ML7213 IOH

Hi Iwai,

(2011/10/21 23:16), Takashi Iwai wrote:
> At Mon, 17 Oct 2011 13:28:39 +0900,
> Tomoya MORINAGA wrote:
>>
>> Hi Iwai,
>>
>> We have just started porting to ASoC structure.
>
> Please add ASoC maintainers to Cc if you have questions about ASoC.
>
>> I have a question.
>>
>> As you reviewed before, currently, our driver consists of 2 parts,
>> Soundcard driver and I2S driver.
>>
>> Soundcard consists of 2 parts
>>     - ALSA interface / control part
>>     - CODEC control part
>>
>> I2S driver consists of 4 parts
>>    - HAL
>>    - DMA control / interrupt control
>>    - Soundcard interface part
>>    - PCI interface function
>>
>> According to "soc" Documentation,
>> We must divide to 3 parts, platform driver, machine driver and codec driver.
>>
>> So, I divided like the following parts.
>>
>> platform driver
>>    - ALSA interface / control part
>>    - HAL
>>    - DMA control / interrupt control
>>    - Soundcard interface part
>>    - PCI interface function
>>
>> machine driver
>>    - (none)
>>
>> codec driver
>>     - CODEC control part
>>
>> Is the above dividing true ?
>
> Not really.  ASoC is designed to be much more modular.  Take a look at
> the codes in sound/soc/*.  You'll grasp how the components are split.
> (The documents in Documentation/sound/alsa/soc/ are slightly
>   obsoleted...)

Of course, I read Documentation/sound/alsa/soc/ and sound/soc/*.
However, it's not easy for me.

I have just 2 questions.

1. PCI interface function.
Any current ASoC drivers don't have PCI interface function.
So I don't know where the function should be in machine driver or 
platform driver.

2. Register Access
Can platform driver access register ?
According to the soc document, platform driver must not access hardware,
however, some drivers looks accessing their hardware.

>
> The conversion of PCM part is usually straightforward, as found in
> *-pcm.c.  The DAI setup depends on the hardware implementation.
> That's for machine driver.  But it's hard to tell in more details
> until I see the actual code snippet you are working on...

I understand.
I'm going to send our modified driver soon.

Thanks,

-- 
tomoya
ROHM Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/