linux-kernel - Re: [GIT PULL] pinctrl subsystem creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Oct 2011 14:11:33 +0200
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	jesper.nilsson@...s.com, Stephen Warren <swarren@...dia.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	Rongjun Ying <rongjun.ying@....com>,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] pinctrl subsystem creation

On Tue, Oct 25, 2011 at 12:11 PM, Linus Walleij
<linus.walleij@...aro.org> wrote:
>
> this is a new subsystem in a new git so given all the current
> GnuPG signing and hoopla the probability of this being rejected
> for one or another reason tends to one. But anyway, here goes:

Hmm. No problem. At least it's not some open git repo, and yes, I can
check your gpg key - although whether it's actually *yours* I don't
know, because I don't know the people who signed it ;)

But anyway, looks good.

Except I wonder why you even made that CONFIG_PINCTRL user-visible?
Any driver that uses the interface had better have a "select PINCTRL"
in it, so actually asking the user whether they want that subsystem
seems to be just annoying and pointless, no?

So I suspect it should just be made a "def_bool n"?

And I hope all these new lines will result in more deleted lines later...

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/