lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Oct 2011 14:52:17 +0800 From: Shawn Guo <shawn.guo@...escale.com> To: Rajendra Nayak <rnayak@...com> CC: Grant Likely <grant.likely@...retlab.ca>, <broonie@...nsource.wolfsonmicro.com>, <patches@...aro.org>, <tony@...mide.com>, <devicetree-discuss@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>, <lrg@...com>, <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v2 3/5] regulator: helper routine to extract regulator_init_data On Tue, Oct 25, 2011 at 11:30:19AM +0530, Rajendra Nayak wrote: > On Monday 24 October 2011 07:17 PM, Shawn Guo wrote: > >On Mon, Oct 24, 2011 at 02:43:58PM +0530, Rajendra Nayak wrote: > >>Case 2: > >>One device for all regulators: > >> > >>DT nodes look something like this > >> > >>regulators { > >> reg1: reg@1 { > >> ... > >> ... > >> }; > >> > >> reg2: reg@2 { > >> ... > >> ... > >> }; > >>}; > >> > >>The regulator driver probes only one device and the dev->of_node > >>points to the "regulators" node above. > > > >The mc13892 example I put in the reply to Grant demonstrates that > >for some case, dev->of_node is NULL (devices are created by mfd core). > > In that case should you not be first converting the mfd driver to > register regulator devices using DT? The mc13892 mfd driver calls mfd_add_devices() to add device for mc13892 regulator driver. Are you suggesting that I should hack mfd_add_devices() to have device_node of 'regulators' attached? The mfd is not a bus like i2c and spi, so I'm not sure this is the right thing to do. > Thats what we did for OMAP, and hence we always have the of_node > populated when the regulator devices are probed. > See this patch from Benoit on how thats done for twl devices.. > http://marc.info/?l=linux-omap&m=131489864814428&w=2 > OMAP is "Case 1", and we are talking about "Case 2". -- Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists