linux-kernel - Re: [PATCH 2/2] ASoC: tlv320aic3x: Clear BIT_CLK_MASTER and WORD_CLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Oct 2011 10:17:06 +0100
From:	"Girdwood, Liam" <lrg@...com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Vladimir Barinov <vbarinov@...eddedalley.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Jarkko Nikula <jarkko.nikula@...mer.com>,
	Peter Ujfalusi <peter.ujfalusi@...com>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH 2/2] ASoC: tlv320aic3x: Clear BIT_CLK_MASTER and
 WORD_CLK_MASTER bits for for slave mode

On 27 October 2011 09:38, Axel Lin <axel.lin@...il.com> wrote:
> According to the datasheet:
>
> Page0 / Register8: Audio Serial Data interface Control Register A
> BIT 7: Bit Clock Directional Control
>        0: Bit clock is an input (slave mode)
>        1: Bit clock is an output (master mode)
>
> BIT 6: Word Clock Directional Control
>        0: Word clock is an input (slave mode)
>        1: Word clock is an output (master mode)
>
> Current code sets BIT_CLK_MASTER and WORD_CLK_MASTER bits for master mode,
> but does not clear these bits for slave mode.
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  sound/soc/codecs/tlv320aic3x.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
> index a77f6ea..14cb553 100644
> --- a/sound/soc/codecs/tlv320aic3x.c
> +++ b/sound/soc/codecs/tlv320aic3x.c
> @@ -1021,6 +1021,7 @@ static int aic3x_set_dai_fmt(struct snd_soc_dai *codec_dai,
>                break;
>        case SND_SOC_DAIFMT_CBS_CFS:
>                aic3x->master = 0;
> +               iface_areg &= ~(BIT_CLK_MASTER | WORD_CLK_MASTER);
>                break;
>        default:
>                return -EINVAL;
> --
> 1.7.5.4
>
>
>
>

Both

Acked-by: Liam Girdwood <lrg@...com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/