linux-kernel - RE: [PATCH 1/2] pinmux: Remove double pin validity check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Oct 2011 11:42:37 -0700
From:	Stephen Warren <swarren@...dia.com>
To:	Belisko Marek <marek.belisko@...il.com>
CC:	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] pinmux: Remove double pin validity check.

Belisko Marek wrote at Thursday, October 27, 2011 12:40 PM:
> On Thu, Oct 27, 2011 at 6:37 PM, Stephen Warren <swarren@...dia.com> wrote:
> > Belisko Marek wrote at Wednesday, October 26, 2011 2:57 PM:
> >> Function pin_is_valid just call pin_desc_get which is in pin_request
> >> call some line below. Remove pin_is_valid() check.
> > ...
> >> @@ -112,16 +112,6 @@ static int pin_request(struct pinctrl_dev *pctldev,
> >>
> >>       dev_dbg(&pctldev->dev, "request pin %d for %s\n", pin, function);
> >>
> >> -     if (!pin_is_valid(pctldev, pin)) {
> >> -             dev_err(&pctldev->dev, "pin is invalid\n");
> >> -             return -EINVAL;
> >> -     }
> >
> > So that makes sense.
> >
> >> -
> >> -     if (!function) {
> >> -             dev_err(&pctldev->dev, "no function name given\n");
> >> -             return -EINVAL;
> >> -     }
> >
> > But I don't think you want to remove that? Oh actually, perhaps removing
> > that /is/ valid, since it's an internal function and can't be called with
> > a NULL function parameter. But, you should mention why in the changelog
> > so it doesn't look like a mistake.
>
> Well it's not removed. It's moved below pin_desc_get call.

Sigh, so it is. In that case,

Acked-by: Stephen Warren <swarren@...dia.com>

-- 
nvpublic