linux-kernel - [PATCH] x86: fix typo in 32-bit cmpxchg_double

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 27 Oct 2011 14:00:02 -0500
From:	Dan McGee <dpmcgee@...il.com>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH] x86: fix typo in 32-bit cmpxchg_double_local implementation

32-bit has no cmpxchg16b_local; only 8b. This looks like it was copied
from the 64-bit code without adjustment and should resemble
cmpxchg_double as defined in this same file.

Introduced in commit 3824abd1279ef7.

Signed-off-by: Dan McGee <dpmcgee@...il.com>
---
 arch/x86/include/asm/cmpxchg_32.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/cmpxchg_32.h b/arch/x86/include/asm/cmpxchg_32.h
index 3deb725..14b74b5 100644
--- a/arch/x86/include/asm/cmpxchg_32.h
+++ b/arch/x86/include/asm/cmpxchg_32.h
@@ -323,7 +323,7 @@ static inline unsigned long cmpxchg_386(volatile void *ptr, unsigned long old,
 ({									\
        BUILD_BUG_ON(sizeof(*(ptr)) != 4);				\
        VM_BUG_ON((unsigned long)(ptr) % 8);				\
-       cmpxchg16b_local((ptr), (o1), (o2), (n1), (n2));			\
+       cmpxchg8b_local((ptr), (o1), (o2), (n1), (n2));			\
 })
 
 #define system_has_cmpxchg_double() cpu_has_cx8
-- 
1.7.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/