linux-kernel - Re: [PATCH] drivers: pinctrl: add a pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Oct 2011 21:57:17 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Chanho Park <chanho61.park@...sung.com>,
	Stephen Warren <swarren@...dia.com>
Cc:	"Baohua.Song@....com" <Baohua.Song@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH] drivers: pinctrl: add a pin_base for sparse gpio-ranges

On Wed, Oct 26, 2011 at 8:21 AM, Stephen Warren <swarren@...dia.com> wrote:
> [Chanho]
>> -chip a: [32 .. 47]
>> -chip b: [48 .. 55]
>> -
>> -When GPIO-specific functions in the pin control subsystem are called, these
>> -ranges will be used to look up the apropriate pin controller by inspecting
>> -and matching the pin to the pin ranges across all controllers. When a
>> -... [ quit a few lines of documentation removed]
>> -(If the GPIO subsystem is ever refactored to use a local per-GPIO controller
>> -pin space, this mapping will need to be augmented accordingly.)
>
> I'm all for replacing the example here with something more complete, but
> removing all that text from the documentation doesn't seem right.

I agree. Make a real good example illustrating your setup or something
similar, so we all can understand from the documentation how to use
the different bases.

Apart from that the patch looks good.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/