linux-kernel - RE: [PATCH] PM: fix calculation mistake in roll-over cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Oct 2011 12:04:58 +0530
From:	Venu Byravarasu <vbyravarasu@...dia.com>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	"Rafael J. Wysocki" <rjw@...k.pl>, "pavel@....cz" <pavel@....cz>,
	"len.brown@...el.com" <len.brown@...el.com>,
	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Peter De Schrijver <pdeschrijver@...dia.com>
Subject: RE: [PATCH] PM: fix calculation mistake in roll-over cases

> -----Original Message-----
> From: Alan Stern [mailto:stern@...land.harvard.edu]
> Sent: Friday, October 28, 2011 12:00 AM
> To: Venu Byravarasu
> Cc: Rafael J. Wysocki; pavel@....cz; len.brown@...el.com; gregkh@...e.de;
> linux-pm@...r.kernel.org; linux-kernel@...r.kernel.org; Peter De Schrijver
> Subject: RE: [PATCH] PM: fix calculation mistake in roll-over cases
> 
> On Thu, 27 Oct 2011, Venu Byravarasu wrote:
> 
> > > From: venu byravarasu <vbyravarasu@...dia.com>
> > >
> > > In case of jiffies roll over, delta is made zero.
> > > Hence fixing it, after taking roll over into consideration.
> > >
> > > Signed-off-by: venu byravarasu <vbyravarasu@...dia.com>
> > > ---
> 
> > 2. Even if delta is made unsigned, in cases of jiffies roll over, delta will be zero.
> > That is also being taken care with the code added as part of if condition.
> 
> Since delta is now unsigned, the "if (delta < 0)" test can never
> succeed.  Therefore it can be removed.
> 
> The new lines you added with max_num don't seem to serve any useful
> purpose.  All they do is recalculate the same value that delta had
> before, but with an off-by-one error.
> 
Agree with you Alan.
Will remove max_num references and upload the change.

Thanks,
Venu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/