linux-kernel - Re: [PATCH 1/1] Staging: hv: Move the mouse driver out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 29 Oct 2011 09:32:40 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	"K. Y. Srinivasan" <kys@...rosoft.com>, dmitry.torokhov@...il.com,
	jkosina@...e.cz, gregkh@...e.de, ohering@...e.com,
	linux-kernel@...r.kernel.org, virtualization@...ts.osdl.org,
	joe@...ches.com, devel@...uxdriverproject.org
Subject: Re: [PATCH 1/1] Staging: hv: Move the mouse driver out of staging

On Sat, Oct 29, 2011 at 12:54:34AM +0200, Jesper Juhl wrote:
> > +			default:
> > +				pr_err("unhandled packet type %d, tid %llx len %d\n",
> > +				   desc->type,
> > +				   req_id,
> > +				   bytes_recvd);
> 
> Why not:
> 
>                                 pr_err("unhandled packet type %d, tid %llx 
>                                        len %d\n", desc->type, req_id, bytes_recvd);

Because then the printk would be messed up?  Your final printed
string would look like:

"unhandled packet type %d, tid %llx 
                                       len %d\n"

Don't break strings up across lines because it breaks grep.  If K. Y.
wants to put all the parameters on one line instead of three that
would probably be better, but in the end who cares?

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/