linux-kernel - Re: [PATCH 1/2] gpio: pca953x: remove unneeded check for chip type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 29 Oct 2011 12:26:46 +0200
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] gpio: pca953x: remove unneeded check for chip type

On Sat, Oct 29, 2011 at 08:58:20AM +0200, Wolfram Sang wrote:
> On Fri, Oct 14, 2011 at 03:31:59PM +0200, Wolfram Sang wrote:
> > We can assume our own device_id table is correct, so remove checking if
> > the chip type is valid. (The check was bogus anyway: If it found an
> > invalid entry, it returned with 0!) This is in preparation for further
> > cleanups.
> > 
> > Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
> > Cc: Grant Likely <grant.likely@...retlab.ca>
> 
> Ping for this mini-series.

Merged and I'll push out for 3.2, thanks.

g.

> 
> > ---
> >  drivers/gpio/gpio-pca953x.c |    4 +---
> >  1 files changed, 1 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> > index c43b8ff..45de6a4 100644
> > --- a/drivers/gpio/gpio-pca953x.c
> > +++ b/drivers/gpio/gpio-pca953x.c
> > @@ -673,10 +673,8 @@ static int __devinit pca953x_probe(struct i2c_client *client,
> >  
> >  	if (chip->chip_type == PCA953X_TYPE)
> >  		device_pca953x_init(chip, invert);
> > -	else if (chip->chip_type == PCA957X_TYPE)
> > -		device_pca957x_init(chip, invert);
> >  	else
> > -		goto out_failed;
> > +		device_pca957x_init(chip, invert);
> >  
> >  	ret = pca953x_irq_setup(chip, id, irq_base);
> >  	if (ret)
> > -- 
> > 1.7.6.3
> > 
> 
> -- 
> Pengutronix e.K.                           | Wolfram Sang                |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/