linux-kernel - Re: [PATCH] mmc: omap_hsmmc: Fix build for hsmmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Nov 2011 19:57:08 +0100
From:	Thomas Weber <thomas.weber.linux@...glemail.com>
To:	Tony Lindgren <tony@...mide.com>
Cc:	Chris Ball <cjb@...top.org>, linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org, linux-omap@...r.kernel.org,
	Girish K S <girish.shivananjappa@...aro.org>
Subject: Re: [PATCH] mmc: omap_hsmmc: Fix build for hsmmc

Hello Tony, hello
Chris,https://mail.google.com/mail/?shva=1#label/linux-omap/133653efb30ae047

isn't this already fixed?

http://marc.info/?l=linux-omap&m=131991921316862&w=2

[PATCH] omap_hsmmc: fix missing parenthesis in pr_info

Thomas

On Wed, Nov 2, 2011 at 6:06 PM, Tony Lindgren <tony@...mide.com> wrote:
> Commit a3c76eb9d4a1e68a69dd880cf0bcb8a52418b993 (mmc: replace
> printk with appropriate display macro) does not compile:
>
> drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_protect_card':
> drivers/mmc/host/omap_hsmmc.c:1273: error: 'pr_info' undeclared (first use in this function)
> drivers/mmc/host/omap_hsmmc.c:1273: error: (Each undeclared identifier is reported only once
> drivers/mmc/host/omap_hsmmc.c:1273: error: for each function it appears in.)
> drivers/mmc/host/omap_hsmmc.c:1273: error: expected ';' before string constant
> drivers/mmc/host/omap_hsmmc.c:1275: error: expected statement before ')' token
> distcc[15197] ERROR: compile drivers/mmc/host/omap_hsmmc.c on localhost failed
>
> Cc: Girish K S <girish.shivananjappa@...aro.org>
> Cc: Chris Ball <cjb@...top.org>
> Cc: linux-mmc@...r.kernel.org
> Signed-off-by: Tony Lindgren <tony@...mide.com>
>
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1270,7 +1270,7 @@ static void omap_hsmmc_protect_card(struct omap_hsmmc_host *host)
>                }
>        } else {
>                if (!host->protect_card) {
> -                       pr_info"%s: cover is open, "
> +                       pr_info("%s: cover is open, "
>                                         "card is now inaccessible\n",
>                                         mmc_hostname(host->mmc));
>                        host->protect_card = 1;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/