linux-kernel - Re: [050/107] block: check for proper length of iov entries earlier in blk_rq_map_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 4 Nov 2011 14:04:47 -0700
From:	Greg KH <gregkh@...e.de>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Ben Hutchings <ben@...adent.org.uk>,
	Xiaotian Feng <dfeng@...hat.com>,
	Jens Axboe <jaxboe@...ionio.com>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk
Subject: Re: [050/107] block: check for proper length of iov entries earlier
 in blk_rq_map_user_iov()

On Sat, Nov 05, 2011 at 12:00:55AM +0300, Dan Carpenter wrote:
> On Fri, Nov 04, 2011 at 01:28:06PM -0700, Greg KH wrote:
> > Doesn't this still fix one issue here, just not both of them described,
> > right?
> 
> Not really.
> 
> We've got a list from 0 - 100.  We should be checking them all.
> If number 50 is unaligned in the old version we would check 0 - 50,
> but with this patch applied we check from 0 to 51.

Ugh, you are right.

Xiaotian, please fix this correctly upstream, I'll go drop this patch
for now from the stable trees.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/