linux-kernel - Re: [PATCH] Hexagon: Use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Nov 2011 17:02:02 -0800
From:	David Brown <davidb@...eaurora.org>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	Richard Kuo <rkuo@...eaurora.org>, Arnd Bergmann <arnd@...db.de>,
	linux-hexagon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Hexagon: Use resource_size function

Some minor nits about the formatting of the patch.

On Tue, Nov 08, 2011 at 07:49:30PM +0100, Thomas Meyer wrote:
> From: Thomas Meyer <thomas@...3r.de>

Shouldn't need a From: line, since it is the same as the email you
sent it from.

>  Use resource_size function on resource object
>  instead of explicit computation.

The commit text shouldn't be indented.

>  The semantic patch that makes this change is available
>  in scripts/coccinelle/api/resource_size.cocci.
> 
>  More information about semantic patching is available at
>  http://coccinelle.lip6.fr/

I'm curious if these patches are generated directly by coccinelle,
since they don't appear to be coming from git.  It'd be nice to have
diffstats in them (especially when they are larger).

Thanks,
David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/