lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 09 Nov 2011 17:34:46 -0800 From: Bryan Huntsman <bryanh@...eaurora.org> To: Harini Jayaraman <harinij@...eaurora.org> CC: grant.likely@...retlab.ca, davidb@...eaurora.org, kheitke@...eaurora.org, linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, spi-devel-general@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH] spi: QUP based bus driver for Qualcomm MSM chipsets On 11/09/2011 05:07 PM, Harini Jayaraman wrote: > This bus driver supports the QUP SPI hardware controller in the Qualcomm > MSM SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general > purpose data path engine with input/output FIFOs and an embedded SPI > mini-core. The driver currently supports only FIFO mode. > > Signed-off-by: Harini Jayaraman <harinij@...eaurora.org> > --- > drivers/spi/Kconfig | 10 + > drivers/spi/Makefile | 1 + > drivers/spi/msm_spi_qsd.h | 436 +++++++++++++ > drivers/spi/spi-qsd.c | 1144 +++++++++++++++++++++++++++++++++ > include/linux/platform_data/msm_spi.h | 19 + > 5 files changed, 1610 insertions(+), 0 deletions(-) > create mode 100644 drivers/spi/msm_spi_qsd.h > create mode 100644 drivers/spi/spi-qsd.c > create mode 100644 include/linux/platform_data/msm_spi.h A few high-level comments to start. Let's drop 'qsd' from all the names. We haven't used that naming convention for several years now. Better to just call this 'spi-qup.[ch]'. Also, please update the copyright dates. This driver existed before 2011. Thanks. - Bryan -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists