linux-kernel - Re: [PATCH] backing-dev: ensure wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Nov 2011 13:28:03 +0100
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Linus Walleij <linus.walleij@...ricsson.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rabin Vincent <rabin.vincent@...ricsson.com>,
	"stable@...nel.org" <stable@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] backing-dev: ensure wakeup_timer is deleted

On 2011-11-10 10:07, Linus Walleij wrote:
> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> index a086064..71034f4 100644
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -724,6 +724,14 @@ void bdi_destroy(struct backing_dev_info *bdi)
>  
>  	bdi_unregister(bdi);
>  
> +	/*
> +	 * If bdi_unregister() had already been called earlier, the
> +	 * wakeup_timer could still be armed because bdi_prune_sb()
> +	 * can race with the bdi_wakeup_thread_delayed() calls from
> +	 * __mark_inode_dirty().
> +	 */
> +	del_timer_sync(&bdi->wb.wakeup_timer);
> +
>  	for (i = 0; i < NR_BDI_STAT_ITEMS; i++)
>  		percpu_counter_destroy(&bdi->bdi_stat[i]);

Thanks, makes sense, applied.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/