linux-kernel - Re: function_graph selftest fails with !DYNAMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Nov 2011 22:25:55 +0530
From:	Rabin Vincent <rabin@....in>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: function_graph selftest fails with !DYNAMIC

On Fri, Nov 04, 2011 at 09:44:29AM -0400, Steven Rostedt wrote:
> On Wed, 2011-11-02 at 20:32 +0530, Rabin Vincent wrote:
> > The function_graph selftest fails when CONFIG_DYNAMIC_FTRACE is not set
> > (tested on x86-64) on current kernels:
> > 
> > [    0.300124] Testing tracer function: PASSED
> > [    0.446092] Testing tracer function_graph: .. no entries found ..FAILED!
> > 
> > Bisecting goes back to this commit:
> > 
> > 2b499381bc50ede01b3d8eab164ca2fad00655f0 is the first bad commit
> 
> Your bisect is wrong. I ran it though ktest.pl and it gave me this
> bisect commit:

Odd.  2b499381bc50ede really doesn't work for me.  2b499381bc50ede^
does, so the bisect to 2b499381bc50ede seems correct for my config.

It appears I'm seeing a different problem, because ...

> The simple fix is:
> 
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -151,7 +151,6 @@ void clear_ftrace_function(void)
>         ftrace_pid_function = ftrace_stub;
>  }
>  
> -#undef CONFIG_HAVE_FUNCTION_TRACE_MCOUNT_TEST
>  #ifndef CONFIG_HAVE_FUNCTION_TRACE_MCOUNT_TEST
>  /*
>   * For those archs that do not test ftrace_trace_stop in their

... this doesn't seem to fix it.  I've test 3.2-rc1 with this patch
applied, and the self-test failure is still seen.

Maybe there's some difference between our configs?  I've attached mine.
I run it with the "native linux KVM tool".

View attachment "kvm-config" of type "text/plain" (48674 bytes)