linux-kernel - Re: [PATCH 2/2] devfreq: separate error paths from successful path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Nov 2011 04:09:35 +0000 (GMT)
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	Axel Lin <axel.lin@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:	Kevin Hilman <khilman@...com>,
	박경민 <kyungmin.park@...sung.com>,
	Mike Turquette <mturquette@...com>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH 2/2] devfreq: separate error paths from successful path

Sender : Axel Lin<axel.lin@...il.com> Date : 2011-11-10 16:30 (GMT+09:00)
> I think this change improves readability.
> 
> Signed-off-by: Axel Lin 

I agree. It makes it easier to read.

Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>

> ---
> drivers/devfreq/devfreq.c |   15 +++++++--------
> 1 files changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 59d24e9..c189b82 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -347,7 +347,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
> if (!IS_ERR(devfreq)) {
> dev_err(dev, "%s: Unable to create devfreq for the device. It already has one. ", __func__);
> err = -EINVAL;
> - goto out;
> + goto err_out;
> }
> }
> 
> @@ -356,7 +356,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
> dev_err(dev, "%s: Unable to create devfreq for the device ",
> __func__);
> err = -ENOMEM;
> - goto out;
> + goto err_out;
> }
> 
> mutex_init(&devfreq->lock);
> @@ -399,17 +399,16 @@ struct devfreq *devfreq_add_device(struct device *dev,
>    devfreq->next_polling);
> }
> mutex_unlock(&devfreq_list_lock);
> - goto out;
> +out:
> + return devfreq;
> +
> err_init:
> device_unregister(&devfreq->dev);
> err_dev:
> mutex_unlock(&devfreq->lock);
> kfree(devfreq);
> -out:
> - if (err)
> - return ERR_PTR(err);
> - else
> - return devfreq;
> +err_out:
> + return ERR_PTR(err);
> }
> 
> /**
> -- 
> 1.7.5.4
>