linux-kernel - Re: [Intel-gfx] [PATCH] i915: Fix bug where screen brightness is not restored

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Nov 2011 21:28:27 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Kamal Mostafa <kamal@...onical.com>
Cc:	Alex Davis <alex14641@...oo.com>,
	Keith Packard <keithp@...thp.com>,
	"mjg@...hat.com" <mjg@...hat.com>, intel-gfx@...ts.freedesktop.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Intel-gfx] [PATCH] i915: Fix bug where screen brightness is	not restored

At Tue, 15 Nov 2011 11:58:38 -0800,
Kamal Mostafa wrote:
> 
> [1  <multipart/signed (7bit)>]
> [1.1  <text/plain; UTF-8 (quoted-printable)>]
> On Mon, 2011-11-14 at 18:42 -0800, Alex Davis wrote:
> > From: Alex Davis<alex14641@...oo.com>
> > 
> > This patch fixes an issue where the screen would remain dark when
> > 
> > a key was pressed when the laptop lid was reopened or after the
> > laptop had gone into power-save mode.
> 
> [cross-posting to intel-gfx]
> 
> Keith, also note that Alex and I did respond to your request to test the
> already committed patch "drm/i915/panel: Always record the backlight
> level again (but cleverly)".  We both determined that patch does *not*
> fix the problem.  Alex's patch below does fix it.

My rough guess is the inconsistency of property taken during the
backlight disabled.  How about the patch below (untested!) in addition
to the fix in 3.2?


Takashi

---
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
index 499d4c0..21f60b7 100644
--- a/drivers/gpu/drm/i915/intel_panel.c
+++ b/drivers/gpu/drm/i915/intel_panel.c
@@ -326,7 +326,8 @@ static int intel_panel_update_status(struct backlight_device *bd)
 static int intel_panel_get_brightness(struct backlight_device *bd)
 {
 	struct drm_device *dev = bl_get_data(bd);
-	return intel_panel_get_backlight(dev);
+	struct drm_i915_private *dev_priv = dev->dev_private;
+	return dev_priv->backlight_level;
 }
 
 static const struct backlight_ops intel_panel_bl_ops = {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/