linux-kernel - Re: [PATCH 1/2] Initial PCI support for Atheros 724x SoCs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Nov 2011 20:50:51 +0100
From:	Manuel Lauss <manuel.lauss@...glemail.com>
To:	Rene Bolldorf <xsecute@...glemail.com>
Cc:	Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Initial PCI support for Atheros 724x SoCs.

Howdy,

On Wed, Nov 16, 2011 at 11:55 AM, Rene Bolldorf <xsecute@...glemail.com> wrote:
> Signed-off-by: Rene Bolldorf <xsecute@...glemail.com>
> ---
>  arch/mips/pci/Makefile      |    1 +
>  arch/mips/pci/ops-ath724x.c |  109 +++++++++++++++++++++++++++++++++++++++++++
>  arch/mips/pci/pci-ath724x.c |   45 ++++++++++++++++++

Why don't you just merge ops-ath724x.c into pci-ath724x.c?  (the only
place where its
contents are referenced)


> diff --git a/arch/mips/pci/ops-ath724x.c b/arch/mips/pci/ops-ath724x.c
> new file mode 100644
> index 0000000..bd3cf15
> --- /dev/null
> +++ b/arch/mips/pci/ops-ath724x.c
> @@ -0,0 +1,109 @@
[...]
> +static int ath724x_pci_read(struct pci_bus *bus, unsigned int devfn, int where,
> +                           int size, uint32_t *value)
> +{
> +       unsigned long flags, addr, tval, mask;
> +
> +       if(devfn)
> +               return PCIBIOS_DEVICE_NOT_FOUND;
> +
> +       if(where & (size - 1))
> +               return PCIBIOS_BAD_REGISTER_NUMBER;

Please run both patches through checkpatch once and fix up the
codingstyle issues it
will complain about (like the two above).


Thanks,
        Manuel Lauss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/