linux-kernel - Re: [PATCH][RESEND] usb : gadget : usbstring : fix style problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Nov 2011 16:51:05 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Michal Nazarewicz <mina86@...a86.com>
CC:	Felipe Balbi <balbi@...com>, Tonylijo <mail@...ylijo.in>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][RESEND] usb : gadget : usbstring : fix style problems

Hello.

On 17-11-2011 16:44, Michal Nazarewicz wrote:

>> @@ -84,8 +90,8 @@ fail:
>> }
>> -/**
>> - * usb_gadget_get_string - fill out a string descriptor
>> +/*
>> + * usb_gadget_get_string - fill out a string descriptor

> Shouldn't that be usb_gadget_get_string() (ie. with parens)?

    Yes, that's kerneldoc format. Also, shouldn't have removed second * in /** 
-- that was there due to kerneldoc convention too.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/