linux-kernel - RE: [PATCH v2] pinctrl: indicate GPIO direction on single GPIO request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Nov 2011 09:02:39 -0800
From:	Stephen Warren <swarren@...dia.com>
To:	Igor Grinberg <grinberg@...pulab.co.il>,
	Linus Walleij <linus.walleij@...ricsson.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Barry Song <21cnbao@...il.com>,
	Shawn Guo <shawn.guo@...escale.com>,
	Thomas Abraham <thomas.abraham@...aro.org>,
	Dong Aisheng <dong.aisheng@...aro.org>,
	Rajendra Nayak <rajendra.nayak@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: RE: [PATCH v2] pinctrl: indicate GPIO direction on single GPIO
 request

Igor Grinberg wrote at Thursday, November 17, 2011 8:29 AM:
> You haven't responded to my request for the previous version...
> Pleaser, see below:
> 
> On 11/17/11 15:46, Linus Walleij wrote:
> > From: Linus Walleij <linus.walleij@...aro.org>
...
> >  static int pin_request(struct pinctrl_dev *pctldev,
> >  		       int pin, const char *function,
> > -		       struct pinctrl_gpio_range *gpio_range)
> > +		       struct pinctrl_gpio_range *gpio_range,
> > +		       bool gpio_direction)
> 
> can this (and other instances) be:
> s/gpio_direction/gpio_direction_out/
> ?
> Because "gpio_direction == true/false" does not make much sense.
> OTOH, "gpio_direction_out == true/false" does make sense.

I agree with this sentiment.

Bikeshedding a little, but is_output is shorter and just as explanatory
to me.

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/