linux-kernel - Re: linux-next: Tree for Nov 16 (infiniband: ib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Nov 2011 19:51:35 +0100
From:	Bart Van Assche <bvanassche@....org>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Linux RDMA <linux-rdma@...r.kernel.org>
Subject: Re: linux-next: Tree for Nov 16 (infiniband: ib_srpt.c)

On Thu, Nov 17, 2011 at 3:34 AM, Randy Dunlap <rdunlap@...otime.net> wrote:
> On 11/15/2011 06:33 PM, Stephen Rothwell wrote:
>> Hi all,
>
>
> When CONFIG_BUG is not enabled:
>
> next-2011-1116/drivers/infiniband/ulp/srpt/ib_srpt.c: In function 'srpt_cm_dreq_recv':
> next-2011-1116/drivers/infiniband/ulp/srpt/ib_srpt.c:2761:3: error: implicit declaration of function '__WARN'
>
>
> jbd2 has a similar issue (still unpatched).  One of the comments in that thread
> was that ext4 probably should use WARN_ON() instead of __WARN().
>
> Or (Arnd said):
> Hmm, my feeling is that we shouldn't do that either, and that jbd2 should
> be changed. If we want a function that does what __WARN() does today, we
> should probably make a conscious decision about what we want it to be called
> and not have it start with "__". <end Arnd>

Thanks for reporting this. The __WARN() statements in ib_srpt are
present in code paths that should never be reached. I'll post a patch
that addresses the build failure.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/