linux-kernel - AVR32 code: Mismatching comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 17 Nov 2011 21:50:37 +0100
From:	Thomas Jarosch <thomas.jarosch@...ra2net.com>
To:	Haavard Skinnemoen <hskinnemoen@...il.com>
CC:	linux-kernel@...r.kernel.org
Subject: AVR32 code: Mismatching comparison

Hi Haavard,

consider this piece of code from
arch/avr32/kernel/module.c:

....
case R_AVR32_GOT18SW:
    if ((relocation & 0xfffe0003) != 0
        && (relocation & 0xfffc0003) != 0xffff0000)
        return reloc_overflow(module, "R_AVR32_GOT18SW",
                    relocation);
    relocation >>= 2;
    /* fall through */
...

cppcheck reports for line 267:
"Mismatching comparison, the result is always true"

This probably needs a fix.

Cheers,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/