linux-kernel - Re: [PATCH] m68k: Remove references to obsolete CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Nov 2011 22:34:47 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-m68k@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, Jiri Kosina <trivial@...nel.org>
Subject: Re: [PATCH] m68k: Remove references to obsolete CONFIG_SERIAL167

On Thu, 2011-11-17 at 22:05 +0100, Geert Uytterhoeven wrote:
> > Why do you care about SERIAL_CONSOLE? If it's only really used by
> > AMIGA_BUILTIN_SERIAL why shouldn't we rename it to
> > AMIGA_BUILTIN_SERIAL_CONSOLE?
> 
> Because SERIAL_CONSOLE is a universal platform-independent symbol.
> Other arches have it as well (but less than in the past).
> 
> As soon as m68k gets a new serial driver, it will be used by 2 drivers again.

If one does
    $ git grep -n  "\<\(CONFIG_\)\?SERIAL_CONSOLE\>" | grep -v defconfig

one gets a few hits (summarized):
- arch/m68k/Kconfig.devices: discussed here;
- arch/sparc/Kconfig: apparently unused, and can be dropped;
- arch/xtensa/Kconfig and arch/xtensa/platforms/iss/console.c: the only
  other current usage (note that the "S6105" platform, mentioned in the
  Kconfig file, seems not to use it);
- drivers/staging/serial/68360serial.c: uses CONFIG_SERIAL_CONSOLE, but
  I don't see how it can actually be set for that driver;
- drivers/tty/amiserial.c: discussed here.

I see nothing universal about it: two independent usages, one in
*/iss/console.c and one in */amiserial.c. So I'd say these can be
renamed to (say) ISS_SERIAL_CONSOLE and AMIGA_BUILTIN_SERIAL_CONSOLE.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/