linux-kernel - Re: [PATCH] ahci: platform support for suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 18 Nov 2011 11:17:48 +0200
From:	Felipe Balbi <balbi@...com>
To:	Brian Norris <computersforpeace@...il.com>
Cc:	balbi@...com, Jeff Garzik <jgarzik@...ox.com>,
	linux-ide@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	Kevin Cernekee <cernekee@...il.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Anton Vorontsov <avorontsov@...mvista.com>,
	linux-pm@...ts.linux-foundation.org
Subject: Re: [PATCH] ahci: platform support for suspend/resume

On Thu, Nov 17, 2011 at 04:31:32PM -0800, Brian Norris wrote:
> +linux-pm mailing list
> 
> Hi Felipe,
> 
> On Wed, Nov 16, 2011 at 12:34 PM, Felipe Balbi <balbi@...com> wrote:
> > On Wed, Nov 16, 2011 at 12:27:59PM -0800, Brian Norris wrote:
> >> +     /* Does platform support suspend/resume? */
> >> +     if (!pdata->suspend || !pdata->resume)
> >> +             return -EINVAL;
> >
> > should you really prevent suspend is platform doesn't provide
> > ->suspend() ?
> 
> No, we shouldn't prevent suspend entirely; that would just be my
> accidental side effect.
> 
> > I mean, we could some platform where all clocks are autogated and
> > there's no need for platform to do anything. Would it be better to only
> > call pdata->suspend if it exists but still let the AHCI-specific part go
> > through ?
> 
> Perhaps. But would this have any unintended effects on systems that
> don't implement AHCI power management at all? My intention was just to
> provide an 'opt-in' interface for platform developers. I probably got
> this wrong.

I guess you could add a flag for that, but until we know that the AHCI
powermanagement is broken somewhere should we really care ? :-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)