linux-kernel - Re: [PATCH] x86, mrst: Casting (void *) value returned by kmalloc is useless

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Nov 2011 15:40:54 +0200
From:	Pekka Enberg <penberg@...nel.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Thomas Meyer <thomas@...3r.de>, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, mrst: Casting (void *) value returned by kmalloc is useless

> On Thu, 17 Nov 2011 23:43:40 +0100
> Thomas Meyer <thomas@...3r.de> wrote:
>
>> The semantic patch that makes this change is available
>> in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.
>>
>> Signed-off-by: Thomas Meyer <thomas@...3r.de>
>> ---
>>
>> diff -u -p a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
>> --- a/arch/x86/platform/mrst/mrst.c 2011-11-07 19:37:40.283168752 +0100
>> +++ b/arch/x86/platform/mrst/mrst.c 2011-11-08 09:19:24.686513740 +0100
>> @@ -331,7 +331,7 @@ static int __init sfi_parse_gpio(struct
>>       num = SFI_GET_NUM_ENTRIES(sb, struct sfi_gpio_table_entry);
>>       pentry = (struct sfi_gpio_table_entry *)sb->pentry;
>>
>> -     gpio_table = (struct sfi_gpio_table_entry *)
>> +     gpio_table =
>>                               kmalloc(num * sizeof(*pentry), GFP_KERNEL);

On Fri, Nov 18, 2011 at 12:16 PM, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> True but the formatting also wants fixing with that change.

A conversion to kcalloc() would make sense as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/