linux-kernel - RE: [PATCH] scsi_dh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Nov 2011 09:34:01 -0500
From:	"Moger, Babu" <Babu.Moger@...app.com>
To:	"Richard Weinberger" <richard@....at>, <JBottomley@...allels.com>
Cc:	<Somasundaram.Krishnasamy@....com>, <yanling.qi@....com>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi_dh_rdac: Fix error path

Looks good to me..

> -----Original Message-----
> From: Richard Weinberger [mailto:richard@....at]
> Sent: Thursday, November 17, 2011 6:44 PM
> To: JBottomley@...allels.com
> Cc: Moger, Babu; Somasundaram.Krishnasamy@....com; yanling.qi@....com;
> linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; Richard
> Weinberger
> Subject: [PATCH] scsi_dh_rdac: Fix error path
> 
> If create_singlethread_workqueue() failes, rdac_init should fail too.
> 
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>  drivers/scsi/device_handler/scsi_dh_rdac.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c
> b/drivers/scsi/device_handler/scsi_dh_rdac.c
> index 1d31279..2802394 100644
> --- a/drivers/scsi/device_handler/scsi_dh_rdac.c
> +++ b/drivers/scsi/device_handler/scsi_dh_rdac.c
> @@ -934,6 +934,8 @@ static int __init rdac_init(void)
>  	if (!kmpath_rdacd) {
>  		scsi_unregister_device_handler(&rdac_dh);
>  		printk(KERN_ERR "kmpath_rdacd creation failed.\n");
> +
> +		r = -EINVAL;
>  	}
>  done:
>  	return r;
> --
> 1.7.7.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/