linux-kernel - Re: [PATCH] Fix comparison using wrong pointer variable in dma debug code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Nov 2011 17:47:20 +0100
From:	Thomas Jarosch <thomas.jarosch@...ra2net.com>
To:	Neil Horman <nhorman@...driver.com>
Cc:	Joerg Roedel <joerg.roedel@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix comparison using wrong pointer variable in dma debug code

On Thursday, 17. November 2011 21:01:36 Neil Horman wrote:
> Thanks for the catch!  Viro just pointed out you can also remove the ?
> true/false changes and extraneous parens, reducing it to:
> 
> (a->dev_addr == b->dev_addr) && (a->dev == b->dev)
> But its not strictly necessecary
> 
> Acked-by: Neil Horman <nhorman@...driver.com>

I'd say just commit the fix, that rarely used function
is not worth the extra effort.

Cheers,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/