linux-kernel - Re: [PATCH] include/log2.h: Fix rounddown_pow_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Nov 2011 10:46:31 -0800 (PST)
From:	Andrei Warkentin <awarkentin@...are.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	Rolf Eike Beer <eike-kernel@...tec.de>,
	opensuse-kernel@...nsuse.org,
	Sergiu Iordache <sergiu@...omium.org>,
	Marco Stornelli <marco.stornelli@...il.com>,
	Eddie Wai <eddie.wai@...adcom.com>,
	Jayamohan Kallickal <jayamohan.kallickal@...lex.com>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Andrei Warkentin <andreiw@...are.com>
Subject: Re: [PATCH] include/log2.h: Fix rounddown_pow_of_two(1)

Hi,

----- Original Message -----
> From: "Andrew Morton" <akpm@...ux-foundation.org>
> To: "Andrei Warkentin" <andreiw@...are.com>
> Cc: linux-kernel@...r.kernel.org, "Rolf Eike Beer" <eike-kernel@...tec.de>, opensuse-kernel@...nsuse.org, "Sergiu
> Iordache" <sergiu@...omium.org>, "Marco Stornelli" <marco.stornelli@...il.com>, "Eddie Wai"
> <eddie.wai@...adcom.com>, "Jayamohan Kallickal" <jayamohan.kallickal@...lex.com>, "Guennadi Liakhovetski"
> <g.liakhovetski@....de>
> Sent: Thursday, November 17, 2011 6:05:49 PM
> Subject: Re: [PATCH] include/log2.h: Fix rounddown_pow_of_two(1)
> 
> 
> I assume that nobody has gone off and checked whether all current
> callers will survive this change.  If they had, they'd have looked in
> drivers/char/ramoops.c and seen:
> 
> 	rounddown_pow_of_two(pdata->mem_size);
> 	rounddown_pow_of_two(pdata->record_size);
> 
> These operations are no-ops.  It should be
> 
> 	pdata->mem_size = rounddown_pow_of_two(pdata->mem_size);
> 	pdata->record_size = rounddown_pow_of_two(pdata->record_size);
> 
> Marco or Sergio: please fix, test and send it over sometime?

I did quickly look through for code that expected rounddown_pow_of_two(1) to give 0,
but I didn't apparently look close enough for other issues.

A
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/