linux-kernel - Re: [PATCH v2] x86: remove NX from video bios area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Nov 2011 12:45:15 +0800
From:	wangyanqing <udknight@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	torvalds@...ux-foundation.org, castet.matthieu@...e.fr,
	akpm@...ux-foundation.org, x86@...nel.org, spock@...too.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86: remove NX from video bios area

On Thu, Nov 17, 2011 at 06:56:46AM -0800, H. Peter Anvin wrote:
> On 11/17/2011 12:26 AM, wangyanqing wrote:
> >  
> > +/*we hope this the right video bios range*/
> > +#define VIDEO_BIOS_BEGIN	0x000c0000
> > +#define VIDEO_BIOS_END		0x000c7fff
> > +
> >  #define BIOS_ROM_BASE		0xffe00000
> >  #define BIOS_ROM_END		0xffffffff
> 
> Ick.  This feels increasingly hacky, especially since the above is known
> to not be the video BIOS range on a lot of reasons.
> 
> There is something much more fundamentally wrong here, including why X
> permission is needed for uvesafb at all.
> 
> 	-hpa
> 
> -- 
> H. Peter Anvin, Intel Open Source Technology Center
> I work for Intel.  I don't speak on their behalf.
Sorry for my bad idea!
Indeed v86d have double backend to execute x86 video bios code,
one is lrmi(linux real mode interface), another is x86emu.Yesterday,
I compile the v86d with x86emu.Below is the new maps:

08048000-0805e000 r-xp 00000000 00:01 3324       /sbin/v86d 
0805e000-0805f000 rw-p 00015000 00:01 3324       /sbin/v86d 
0805f000-08060000 rw-p 00000000 00:00 0 
b7713000-b7733000 rw-s 000e0000 00:01 3234       /dev/mem 
b7733000-b7742000 rw-s 000c0000 00:01 3234       /dev/mem 
b7742000-b7762000 rw-s 000a0000 00:01 3234       /dev/mem 
b7762000-b7763000 rw-s 0009c000 00:01 3234       /dev/mem 
b7763000-b7764000 rw-s 00000000 00:01 3234       /dev/mem 
b7764000-b7784000 rw-p 00000000 00:01 3230       /dev/zero
b7784000-b7785000 r-xp 00000000 00:00 0          [vdso]
bf98a000-bf9ab000 rw-p 00000000 00:00 0          [stack]

As you see,  now v86d doesn't need the X permission.But 
my machine still hang very early(verbose show uvesafb some 
messages, then black screen, it hangs!)

But if I make the BIOS range X unconditionally, the problem is gone.
So we need more hacky.Any comment is welcome.

Sorry again for the bad patch "[PATCH v2] x86: remove NX from video bios area",
it even can't compile, and it also can't solve myself problem, I haven't test it 
before send it out, I willn't make the same mistake again.

Thanks for all you time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/