linux-kernel - RE: [PATCH TRIVIAL 1/5] Input: keyboard: use macro module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Nov 2011 14:15:09 -0600
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	JJ Ding <jj_ding@....com.tw>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Grant Likely <grant.likely@...retlab.ca>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	JJ Ding <dgdunix@...il.com>
Subject: RE: [PATCH TRIVIAL 1/5] Input: keyboard: use macro
 module_platform_driver()

On Tuesday, November 22, 2011 2:01 AM, JJ Ding wrote:
> 
> Commit 940ab88962bc1aff3273a8356d64577a6e386736 introduced a new macro to
> save some platform_driver boilerplate code. Use it.
> 
> Signed-off-by: JJ Ding <dgdunix@...il.com>
> ---
>  drivers/input/keyboard/ep93xx_keypad.c      |   14 +-------------
> 
> diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
> index 4662c5d..0ba69f3 100644
> --- a/drivers/input/keyboard/ep93xx_keypad.c
> +++ b/drivers/input/keyboard/ep93xx_keypad.c
> @@ -390,19 +390,7 @@ static struct platform_driver ep93xx_keypad_driver = {
>  	.suspend	= ep93xx_keypad_suspend,
>  	.resume		= ep93xx_keypad_resume,
>  };
> -
> -static int __init ep93xx_keypad_init(void)
> -{
> -	return platform_driver_register(&ep93xx_keypad_driver);
> -}
> -
> -static void __exit ep93xx_keypad_exit(void)
> -{
> -	platform_driver_unregister(&ep93xx_keypad_driver);
> -}
> -
> -module_init(ep93xx_keypad_init);
> -module_exit(ep93xx_keypad_exit);
> +module_platform_driver(ep93xx_keypad_driver);
>  
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("H Hartley Sweeten <hsweeten@...ionengravers.com>");

Acked-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

Thanks!