linux-kernel - Re: Regression in thinkpad-acpi events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Nov 2011 10:25:44 +0100
From:	Tom Gundersen <teg@...m.no>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:	maciej.rutecki@...il.com, Natanji <natanji@...il.com>,
	linux-acpi@...r.kernel.org, lenb@...nel.org,
	ibm-acpi-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: Regression in thinkpad-acpi events

Hi Henrique,

On Wed, Nov 16, 2011 at 12:03 AM, Henrique de Moraes Holschuh
<hmh@....eng.br> wrote:
>> As requested:
>> # grep . /sys/bus/platform/devices/thinkpad*/*
>> /sys/bus/platform/devices/thinkpad_acpi/hotkey_enable:1
>> /sys/bus/platform/devices/thinkpad_acpi/hotkey_mask:0x008dffff
>> /sys/bus/platform/devices/thinkpad_acpi/hotkey_poll_freq:10
>> /sys/bus/platform/devices/thinkpad_acpi/hotkey_radio_sw:1
>> /sys/bus/platform/devices/thinkpad_acpi/hotkey_recommended_mask:0x008dffff
>> /sys/bus/platform/devices/thinkpad_acpi/hotkey_report_mode:1
>> /sys/bus/platform/devices/thinkpad_acpi/hotkey_source_mask:0x00000000
>
> Well, the driver has connected to the firmware, and should be working.  And
> there were no changes to the code from v3.0 to v3.1.1.  So, it is either a
> bug in something else, a problematic interaction of the driver with
> something else, or a latent thinkpad-acpi bug that some change elsewhere has
> exposed.
>
> Are the events reported by acpi_listen from arch-linux exactly the same in
> v3.0.9 and v3.1.1 ?  I know some events are missing in your v3.1.1, but I am
> interested in the ones that do get reported.
>
> Although you really should be using the input device for the hotkeys, and
> not any of the 0x10xx events.  Those are driver-specific and deprecated, it
> is all explained in Documentation/laptops/thinkpad-acpi.txt.  So, it really
> might mean that you have something in userspace reading that input device
> and synthesizing the ACPI HKEY events thinkpad-acpi deprecated for a long
> time now.  I know some distros did that instead of switching to an
> input-device-based hotkey daemon.  Please check for that possibility,
> that daemon could be the one having problems with 3.1.1...

It looks like my problem was something else. We don't do anything to
synthesize the ACPI HKEY events (AFAIK), so I believe that KDE (which
I am using) should be using the input events and that the HKEY stuff
does not matter.

I am still trying to figure out why my laptop does not always go to
sleep when I close my lid, but it turns out that I cannot reproduce it
reliably so it is taking me some time.

As to the original report about the change in HKEY events, this is
(probably) due to PROCFS_ACPI being disabled in the Arch kernel as of
3.1.

Cheers,

Tom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/